Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for a connection string #140

Merged
merged 2 commits into from
Apr 8, 2023
Merged

feat: add support for a connection string #140

merged 2 commits into from
Apr 8, 2023

Conversation

sromic
Copy link
Contributor

@sromic sromic commented Dec 24, 2022

Adding support for a connection string option.

Related to the issue: #115

@sromic
Copy link
Contributor Author

sromic commented Jan 3, 2023

Hi @jeremydaly
please review this PR and if you think this makes sense to be added to this awesome lib :)

naorpeled
naorpeled approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@naorpeled naorpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
let's add a test to validate this though

@sromic
Copy link
Contributor Author

sromic commented Jan 18, 2023

LGTM, let's add a test to validate this though

@naorpeled tests are added :)
Also did a little refactoring on config method as well as ts type def.

@naorpeled
Copy link
Collaborator

LGTM, let's add a test to validate this though

@naorpeled tests are added :)
Also did a little refactoring on config method as well as ts type def.

Awesome, will talk to Jeremy and aim to merge this sometime throughout the weekend

@sromic
Copy link
Contributor Author

sromic commented Mar 25, 2023

@naorpeled any news on this?

@naorpeled
Copy link
Collaborator

naorpeled commented Mar 26, 2023 •
edited
Loading

@naorpeled any news on this?

Hey,
sorry for the delay, was super swamped with stuff to do and forgot about this.

Will message Jeremy now 🙏

@naorpeled
Copy link
Collaborator

Hey @sromic,
updating that I've sent a message to Jeremy 2 days ago.
Will let you know when I have any updates 🙏

@sromic
Copy link
Contributor Author

sromic commented Mar 27, 2023

Hey @sromic, updating that I've sent a message to Jeremy 2 days ago. Will let you know when I have any updates 🙏

@naorpeled Much appreciated!

@naorpeled naorpeled changed the title CHANGE - added support for a connection string feat: add support for a connection string Apr 8, 2023
@naorpeled naorpeled merged commit 0592ac3 into jeremydaly:master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naorpeled naorpeled naorpeled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sromic @naorpeled